Turnkey fresh-worktree dev env: atomic per-checkout e2e ports, bootstrap, leak reaper#973
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | ad84e39 | Commit Preview URL Branch Preview URL |
Jun 12 2026, 04:32 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | ad84e39 | Jun 12 2026, 04:35 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
…fast, bootstrap script - e2e ports are now derived from a hash of the checkout root (42000-45999 blocks) so concurrent worktrees never collide; E2E_*_PORT/URL still override. - globalsetups fail fast with the squatting PID when a port is taken instead of silently attaching to a foreign checkout's dev server (the cause of 31-scenario auth-error cascades). - scripts/bootstrap.ts: one idempotent command for submodules + install + playwright; scripts/reap-dev-servers.ts kills orphaned dev stacks. - e2e: bun run ports prints this checkout's derived ports. - sources-api scenario: align with payload-first OpenAPI results (PR #956 changed the product, the cloud-only scenario was not updated). - AGENTS.md: fresh-worktree setup + environment gotchas (fish shell, /tmp scripts, bun.lock conflicts, per-checkout ports).
The hash-derived block was only collision-unlikely (28 checkouts over 400 blocks is birthday-paradox territory), and probe-then-bind raced. Each block now reserves its last port as a lock held for the suite's lifetime: claimPorts binds the lock (atomic — two racing suites can't both win), probes the remaining ports for squatters, and walks forward block-by-block until it owns a fully free block, publishing the claimed ports via E2E_*_PORT env so test workers agree. Explicit env pins skip claiming entirely. Verified by squatting the preferred block's lock+selfhost ports and watching the suite relocate one block over and pass 17/17.
Nothing imports from vendor/ at runtime — the forks are consumed as published npm packages (vendor/README.md is explicit). Forcing the submodule init in bootstrap taught every fresh worktree a false dependency. --forks remains for deliberately developing a fork.
RhysSullivan
force-pushed
the
claude/gracious-satoshi-42e8e9
branch
from
f709965 to
ad84e39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running the e2e suite from a fresh worktree failed 31/78 cloud scenarios with misleading auth errors ("AuthKit emulator did not redirect (403)", "No organization in session"). Root cause: every checkout shared the same default ports (4798/4799/...), a leaked vite dev server from another checkout was squatting 4798, vite's
--strictPortexit was swallowed by the boot glue, andwaitForHttpsilently attached to the foreign checkout's server. Fresh worktrees also start with empty vendor submodules and unbuilt internal packages, so the first dev-server boot dies with "Failed to resolve entry for package '@executor-js/vite-plugin'".What
Atomic per-checkout port claiming (
e2e/src/ports.ts)claimPortsbinds the block's reserved lock port (held for the suite's lifetime — two racing suites can't both win), probes the rest for squatters, and walks forward block-by-block until it owns a fully free block.E2E_*_PORTenv so vitest workers (spawned after globalsetup) agree; explicit env pins skip claiming,E2E_<TARGET>_URLstill attaches to a running instance.One-command setup (
bun run bootstrap)bun install(prepare hook builds the packages dev servers need) + Playwright chromium. Validated from a cold worktree straight to a green suite.Leak cleanup + run digest
bun run reaplists leaked dev stacks, kills orphans whose checkout is gone (--allfor the rest).cd e2e && bun run portsprints the preferred block;bun run summarydigestsruns/*/result.jsoninto pass/fail counts.Test fix
cloud/sources-api.test.tsstill asserted the pre-Surface tool_not_found from describe.tool and make OpenAPI results payload-first #956{status, data}transport envelope; updated to the payload-first shape with thehttpside channel.Docs
Validation
format:check,lint, e2etypecheckpass.Two pre-existing under-load flakes surfaced during full runs (auth-methods
tool_not_foundrace, connect-handoff modal timeout); both pass in isolation and are unrelated to this change.Stack